Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administrative interface for user additional organisations #2485

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

benshimmin
Copy link
Contributor

We now have the ability to add additional organisations from the app itself via the create/edit user forms.

This replaces the radio list of BEIS + partner organisations with a dropdown, for the primary organisation, and also adds a checkbox list of partner organisations for the additional organisations. Appropriate explanatory hint text is also provided.

We also have a sprinkling of JavaScript to enhance the form such that a user's additional organisation selections cannot include their primary organisation. As a safeguard for users who do not have JavaScript enabled, we have validation in the model for this too.

Screenshots of UI changes

Before

before

After

after
  • Is an ADR required? An ADR should be added if this PR introduces a change to the architecture.
  • Is a changelog entry required? An entry should always be made in CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.
  • Do any environment variables need amending or adding?
  • Have any changes to the XML been checked with the IATI validator? See XML Validation

We now have the ability to add additional organisations from the app itself
via the create/edit user forms.

This replaces the radio list of BEIS + partner organisations with a dropdown,
for the primary organisation, and also adds a checkbox list of partner
organisations for the additional organisations. Appropriate explanatory hint
text is also provided.

We also have a sprinkling of JavaScript to enhance the form such that a user's
additional organisation selections cannot include their primary organisation.
As a safeguard for users who do not have JavaScript enabled, we have validation
in the model for this too.
@benshimmin benshimmin marked this pull request as ready for review December 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant